Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaLearnerGridSearch example #49

Merged
merged 17 commits into from
Jul 8, 2024
Merged

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jul 5, 2024

Rendered version

Checklist

  • Added a CHANGELOG.rst entry

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (58c3741) to head (024e605).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          15       15           
  Lines        1476     1476           
=======================================
  Hits         1401     1401           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review July 5, 2024 13:38
@kklein
Copy link
Collaborator

kklein commented Jul 5, 2024

Thanks for working on this :)

Do you have an understanding of why certain hyperparameters in the grid are nans?
Screenshot 2024-07-05 at 4 18 02 PM

@FrancescMartiEscofetQC
Copy link
Contributor Author

Do you have an understanding of why certain hyperparameters in the grid are nans?

Yes! This is because in this lines the variant_outcome_model is not a LGBMRegressor (a LinearRegression was chosen) therefore the n_estimators or verbose parameters are not defined. I think this default behaviour is nice as it makes clear when some parameter was not used.

@kklein
Copy link
Collaborator

kklein commented Jul 5, 2024

Haha, of course. Let's blame it on the nearing weekend

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great :)

docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
docs/examples/example_gridsearch.ipynb Outdated Show resolved Hide resolved
@kklein
Copy link
Collaborator

kklein commented Jul 8, 2024

Is the illustration of this css-related box intentional?

Screenshot 2024-07-08 at 11 22 18 AM

@FrancescMartiEscofetQC
Copy link
Contributor Author

Is the illustration of this css-related box intentional?

Unfortunately yes, it's to change the font size when displaying dataframes, if not it looks like this:
Screenshot 2024-07-08 at 11 34 34

I tried using cell tags like remove-cell or remove-input as explained here but with remove-cell the code is not ran and therefore the font is too big and with remove-input it still shows the box but when extended it is empty (not sure if this option is better).

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit d8d84fc into main Jul 8, 2024
14 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the gridsearch_example branch July 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants